[erlang-patches] Fix type of error Reason on gen_tcp:send/2

Fredrik fredrik@REDACTED
Mon Feb 11 17:26:18 CET 2013


On 02/11/2013 05:21 PM, Sean Cribbs wrote:
> Fredrik,
>
> I have rebased that branch atop current master.
>
> git fetch git://github.com/seancribbs/otp.git gen_tcp_send_error_closed
>
> https://github.com/seancribbs/otp/compare/erlang:maint...gen_tcp_send_error_closed
> https://github.com/seancribbs/otp/compare/erlang:maint...gen_tcp_send_error_closed.patch
>
> On Mon, Feb 11, 2013 at 8:42 AM, Fredrik<fredrik@REDACTED>  wrote:
>> On 02/11/2013 03:15 PM, Sean Cribbs wrote:
>>> ping
>>>
>>> On Wed, Feb 6, 2013 at 4:39 PM, Sean Cribbs<sean@REDACTED>   wrote:
>>>> When the TCP socket is in passive mode, it is possible that a close
>>>> message has not been delivered to the controlling process before
>>>> calling send/2. This results in the returning {error, closed} to the
>>>> caller, in the same way that recv/2,3 does. This patch adjusts the
>>>> type of the error "Reason" to include the atom 'closed'.
>>>>
>>>> As this is more of a documentation concern, I have based the patch off
>>>> 'maint'.
>>>>
>>>> git fetch git://github.com/seancribbs/otp.git gen_tcp_send_error_closed
>>>>
>>>>
>>>> https://github.com/seancribbs/otp/compare/erlang:maint...gen_tcp_send_error_closed
>>>>
>>>> https://github.com/seancribbs/otp/compare/erlang:maint...gen_tcp_send_error_closed.patch
>>>>
>>>> --
>>>> Sean Cribbs<sean@REDACTED>
>>>> Software Engineer
>>>> Basho Technologies, Inc.
>>>> http://basho.com/
>>>
>>>
>> Hello,
>> Please rebase this patch upon current 'master' branch.
>>
>> --
>>
>> BR Fredrik Gustafsson
>> Erlang OTP Team
>>
>
>
Thanks,
Currently cooking in the 'master-pu' branch.

-- 

BR Fredrik Gustafsson
Erlang OTP Team




More information about the erlang-patches mailing list