[erlang-patches] [erlang-bugs] Unused variable causing v3_kernel crash

Anthony Ramine <>
Mon Feb 4 15:50:10 CET 2013


I squashed your commit with mine; please refetch.

-- 
Anthony Ramine

Le 4 févr. 2013 à 14:43, Björn Gustavsson a écrit :

> Thanks for test suite.
> 
> There are a few issues, though.
> 
> First, the new test cases are not correctly listed
> in the lists in the groups/0 function, so they will
> not actually be run.
> 
> Second, being very paranoid when writing test
> cases, I would make sure that the compiled
> code atually works (in this case, that the function
> with side effects is actually called).
> 
> Here is my suggestion how it can be done. If
> you are fine with my changes, we can simply
> squash my commit into yours.
> 
> https://github.com/bjorng/otp/commit/4e21e16ebc1c012ac52b89ba1b38d6f98cfbac2c
> 
> Note that since there is no good reason for
> keeping the test case case in a separate file,
> I have put all code for unused_multiple_values
> into core_fold_SUITE itself.
> 
> 
> 
> On Mon, Feb 4, 2013 at 12:16 PM, Anthony Ramine <> wrote:
> I added a commit with two test cases, please refetch.
> 
> --
> Anthony Ramine
> 
> Le 4 févr. 2013 à 07:17, Björn Gustavsson a écrit :
> 
> >
> > On Sun, Feb 3, 2013 at 12:32 PM, Anthony Ramine <> wrote:
> > Hi,
> >
> > I've added some details and squashed the two commits together,
> > please refetch.
> >
> > In which suite should I put such a test case?
> >
> >
> > I suggest core_fold_SUITE.
> >
> > --
> > Björn Gustavsson, Erlang/OTP, Ericsson AB
> 
> 
> 
> 
> -- 
> Björn Gustavsson, Erlang/OTP, Ericsson AB



More information about the erlang-patches mailing list