[erlang-patches] [erlang-bugs] syntax_tools anonymous function error

[Anthony Ramine]

Hello again,

I’ve pushed the fix. It is just a partial revert of the previous commit on erl_syntax. Such a thing would have been avoided by basic tests. Or just double checking the documentation about the AST, I’m to blame for that.

Should the AST be made consistent between local and remote implicit funs in R17A? I can write a patch for that. With proper tests and documentation.

	git fetch https://github.com/nox/otp.git fix-OTP-11506

	https://github.com/nox/otp/compare/erlang:maint...fix-OTP-11506
	https://github.com/nox/otp/compare/erlang:maint...fix-OTP-11506.patch

Regards,

-- 
Anthony Ramine

Le 12 déc. 2013 à 17:35, Anthony Ramine <n.oxyde@REDACTED> a écrit :

> This patch breaks reverting of local implicit funs in R16B03.
> 
> We have two ways of fixing this:
> 
> - Making erl_syntax reverts local implicit funs’ parts as concrete values.
> - Change the AST format in a backwards-incompatible way and use abstract values for local implicit funs too.
> 
> My vote is on fixing erl_syntax right now for R16, and change the AST in R17 as we will have maps and named funs anyway in there.
> 
> Sorry for the inconvenience.
> 
> Richard, maybe we should write tests for syntax_tools?
> 
> -- 
> Anthony Ramine
> 
> Le 11 nov. 2013 à 15:42, Henrik Nord <henrik@REDACTED> a écrit :
> 
>> Its moving forward as we speak.
>> 
>> Thank you for your contribution!
>> 
>> On 2013-11-01 12:29, Anthony Ramine wrote:
>>> Ping? This is still « Status: Author » in the Development page.
>>> 
>> 
>> -- 
>> /Henrik Nord Erlang/OTP
>> 
>