[erlang-patches] Implement add_report_sup_handler which calls gen_event:add_sup_handler

Pedram Nimreezi <>
Tue Apr 9 14:27:52 CEST 2013


Following changes have been made..
error_logger_SUITE tests added.
error_logger module specs updated.
better explanation added to commit message.

Branch rebased and updated. Thanks.


On Tue, Mar 12, 2013 at 11:03 AM, Pedram Nimreezi <>wrote:

> Thank you for the update, I'll make the proper changes.
>
> On Tue, Mar 12, 2013 at 10:09 AM, Fredrik <> wrote:
> > On 03/01/2013 08:15 PM, Pedram Nimreezi wrote:
> >>
> >> Hi,
> >>
> >> This patch adds add_report_sup_handler to the error_logger module
> >>
> >> To eliminate the need to go around the error_logger api, this patch
> >> allows for a report_handler to be added via add_sup_handler.
> >>
> >> https://github.com/DeadZen/otp/compare/error-logger-sup_handler.patch
> >> https://github.com/DeadZen/otp/compare/error-logger-sup_handler
> >>
> >> git fetch git://github.com/DeadZen/otp.git error-logger-sup_handler
> >>
> > Hello again,
> > I've got some feedback on your patch.
> > *The patch needs tests and documentation
> > *The spec for add_report_sup_handler/1 is not sufficient, should it be
> > "any()" really?
> > *Your commit message is to short and needs further explanation.
> >
> >
> > --
> >
> > BR Fredrik Gustafsson
> > Erlang OTP Team
> >
> > _______________________________________________
> > erlang-patches mailing list
> > 
> > http://erlang.org/mailman/listinfo/erlang-patches
>
>
>
> --
> /* Sincerely
> --------------------------------------------------------------
> Pedram Nimreezi - Chief Technology Officer  */
>
> // The hardest part of design … is keeping features out. - Donald Norman
>



-- 
/* Sincerely
--------------------------------------------------------------
Pedram Nimreezi - Chief Technology Officer  */

// The hardest part of design … is keeping features out. - Donald Norman
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20130409/cdc777b0/attachment.html>


More information about the erlang-patches mailing list