[erlang-patches] Crypto documentation enhancements for HMAC types

Henrik Nord <>
Mon Oct 1 09:36:22 CEST 2012


Thank you for your contribution!
I have added this branch to 'master-pu'


On 09/29/2012 02:51 PM, Daniel White wrote:
> On Thu, Sep 27, 2012 at 7:14 PM, Sverker Eriksson
> <> wrote:
>> Daniel White wrote:
>>> On Thu, Sep 27, 2012 at 1:51 AM, Sverker Eriksson
>>> <> wrote:
>>>
>>>> Daniel White wrote:
>>>>
>>>>> I'm less sure about whether the second patch as it adds an entry for
>>>>> each sha*_mac function.  Is there a desire to keep both types of
>>>>> interface standard in the long run?  Or is the more general hmac_init
>>>>> suitable enough?
>>>>>
>>>> I think I would prefer a generic hmac(Type, Key, Data) similar to
>>>> hash(Type;Data) that was added in R15B02.
>>>>
> Ok, so I've updated the patchset to utilise the generic interface in
> the RFC-4231 tests, and also to utilise test vectors in RFC-2202 to
> test HMAC-MD5 and HMAC-SHA1.
>
> Additionally, the RFC-4231 tests now include the truncation test (test
> vector 5) to exercise that particular code-path (i.e. hmac/4).
>
> Patch info:
>
> git fetch git://github.com/danielwhite/otp.git crypto-hmac-enhancements
>
> https://github.com/danielwhite/otp/compare/erlang:master...danielwhite:crypto-hmac-enhancements
> https://github.com/danielwhite/otp/compare/erlang:master...danielwhite:crypto-hmac-enhancements.patch
>
> (Sorry about the dupe email, forgot to cc erlang-patches).
>
> Regards,
>

-- 
/Henrik Nord Erlang/OTP



More information about the erlang-patches mailing list