[erlang-patches] better delete_any in gb_{sets, trees}, better difference in gb_sets

Richard Carlsson <>
Thu May 31 14:30:35 CEST 2012


Henrik's comments were a bit terse. I made some more detailed comments 
from an implementation perspective, under

 
https://github.com/erlang/otp/commit/5bb65b7c8db3a9cdc233d2f323581c95614cb3fb

and

 
https://github.com/erlang/otp/commit/5529e94bd91bc410d01a433084d586e98cf408ef

I don't have time to do the changes myself right now, so I'd appreciate 
if you rework your patches along the lines of what I suggested.

    /Richard

On 05/31/2012 02:07 PM, Henrik Nord wrote:
> Hi
> Your branch "gb-delete_any" has been reviewed with the following comments:
>
>
> fma/gb-delete_any
> The commits should have been squashed.
>
> Rejected. Breaks the documentation which says that it does nothing
> if the key is not present.
>
>
> And for you branch "gb_difference" the comments are as follows
>
> fma/gb_difference
> The commits should have been squashed.
>
> Clarify: Explain what is not sane with the current
> gb_sets:difference/2 and gb_sets:is_subset/2.
>
>
> Thank you for your contribution!
>



More information about the erlang-patches mailing list