[erlang-patches] [patch] new float_to_list/2

Lukas Larsson <>
Wed Jul 18 11:18:01 CEST 2012


Hi Serge!

I think the added functionality is a good idea. I will however have to 
discuss it with the floating point experts here before accepting the 
patch (they are currently enjoying their summer vacations).

However, I would also like the fast functionality to be used by 
float_to_list_1 as well, is possible to do this and stay backwards 
compatible? Hopefully you just have to shift the comma and add e+XX at 
the end of the optimized case and call sys_double_to_chars for the 
unoptimized.

Also float_to_list(1.0) should return the same thing as 
float_to_list(1.0,[]), otherwise the API will be inconsistent with how 
other such APIs work.

Lukas

On 24/05/12 16:02, Serge Aleynikov wrote:
> Henrik,
>
> Fetch:	git fetch https://github.com/saleyn/otp/tree/float_to_list_2
> Diff:	https://github.com/saleyn/otp/compare/float_to_list_2
>
> I added the definition for the new BIF to make the type checker happy:
> https://github.com/saleyn/otp/commit/f9ddbeda5426ca83cda03c06a9860220ea4a22c7
>
> Once you do the "otp_build tests", how do you execute all tests suites
> in $ERL_TOP or if possible only tests in a given SUITE?  I tried the
> following but all tests fail:
>
> [otp/erts/emulator/test]$ ../../../bin/erl -noshell -s test_server_ctrl
> run_test DIR "." -s erlang halt
>
> I did however run individual tests in bif_SUIT:types to make sure my
> patch didn't break anything.
>
>
>
> Serge
>
> On 5/24/2012 5:17 AM, Henrik Nord wrote:
>> Hi again.
>>
>>
>> This test is not passing: emulator/bif_SUIT:types
>>
>> No type information:
>>
>> [{erlang,float_to_list,2}]
>>
>>
>>
>> On 04/21/2012 07:19 AM, Serge Aleynikov wrote:
>>> git fetch https://github.com/saleyn/otp/tree/float_to_list_2
> _______________________________________________
> erlang-patches mailing list
> 
> http://erlang.org/mailman/listinfo/erlang-patches
>




More information about the erlang-patches mailing list