[erlang-patches] fixed reading compressed binary terms from Java

Henrik Nord <>
Fri Apr 27 10:23:37 CEST 2012


Hi

I would like you to add a test for this. As there already are compress 
and decompress roundtrip tests,
the effort should be minimal for adding tests for this specific bug.

Also the commit message should conform to
(fix, not fixed etc..)

https://github.com/erlang/otp/wiki/Writing-good-commit-messages

Thank you for the contribution!

On 04/25/2012 10:48 AM, Nico Kruber wrote:
> Problem was that when reading from an InputStream, you can only specify a
> maximum number of bytes to read. Java doesn't guarantee that it actually reads
> this many bytes - it could be less!
>
> This patch now reads up until the expected size number of bytes. If there are
> more than expected, the actual number of available bytes is not printed (we
> probably shouldn't read the additional bytes, security-wise - the erlang
> external byte representation is broken in this case though).
>
> I applied a patch posted on erlang-questins in September 2009, see
> http://erlang.org/pipermail/erlang-patches/2009-September/000478.html
> It was not enough to fix the bug though so I extended this patch a little.
>
> https://github.com/NicoK/otp/compare/jinterface.fix_compressed_binary
> https://github.com/NicoK/otp/compare/jinterface.fix_compressed_binary.patch
>
>
> Regards
> Nico Kruber
> _______________________________________________
> erlang-patches mailing list
> 
> http://erlang.org/mailman/listinfo/erlang-patches

-- 
/Henrik Nord Erlang/OTP



More information about the erlang-patches mailing list