[erlang-patches] Fix for: extremely slow Erlang to/from Java communication via JInterface

[Nico Kruber]

thank you for that tip - I wasn't even aware of Arrays.copyOf being Java6 
only.
I replaced it by your code in my branch.


Nico

On Wednesday 30 November 2011 12:35:14 Vlad Dumitrescu wrote:
> Hi,
> 
> I think that it's easy to fix, just replace that line with
> 
>             final byte[] tmp = new byte[super.count];
>             System.arraycopy(super.buf, 0, tmp, 0, super.count);
>             super.buf = tmp;
> 
> regards,
> Vlad
> 
> 
> On Wed, Nov 30, 2011 at 12:29, Raimo Niskanen
> 
> <raimo+erlang-patches@REDACTED> wrote:
> > On Wed, Nov 30, 2011 at 12:16:29PM +0100, Vlad Dumitrescu wrote:
> >> Hi!
> >> 
> >> 2011/11/30 Nico Kruber <kruber@REDACTED>:
> >> > We discovered, that the communication between Erlang and Java is
> >> > extremely slow when sending longer lists.
> >> > 
> >> > git fetch git://github.com/NicoK/otp.git
> >> > jinterface_better_buffer_alloc
> >> > 
> >> > https://github.com/NicoK/otp/compare/jinterface_better_buffer_allo
> >> > c
> >> > https://github.com/NicoK/otp/compare/jinterface_better_buffer_allo
> >> > c.patch>> 
> >> This patch uses Java 6 features. Isn't jinterface supporting even Java
> >> 5?> 
> > That is correct. JDK 1.5 is the least common denominator.
> > 
> > Then it will not pass our tests.
> > 
> > Is it the java.util.Arrays.copyOf method that is too new, or is
> > it more? Can the patch be rewritten?
> > 
> >> regards,
> >> Vlad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20111130/9067fbec/attachment.bin>