[erlang-patches] DTrace patch, review draft #3

Henrik Nord <>
Tue Nov 22 11:57:11 CET 2011


On 11/21/2011 07:41 AM, Scott Lystig Fritchie wrote:
> Henrik Nord<>  wrote:
>
> hn>  I added this version to 'pu' yesterday for testing
>
> Hi, Henrik.  Over the weekend, I updated the "dtrace-review3" branch
> with two additional commits:
>
>      Add SystemTap README and sample scripts.
>      Bugfixes to dtrace-review3 branch (squashed)
>
> If you'd prefer, I could squash the new SystemTap commit into the "Add
> DTrace support for OS X, Solaris, and Linux (via SystemTap), 2/4"
> commit.  They're related in theme close enough to make sense squashing
> together.
Sounds good
>
> I didn't know what you wanted to see regarding bug and style fixing, so
> I squashed all bug and style fixes into a single commit.  (And would
> squash new bug/style fixes into that same single commit?)
Yes, or into the commits itself, so there is no real "bugfix" commit, 
but these fixes are merged into the different commits, the mechanics 
one, the example programs one, and the one adding probes
>
> I've a related question ... has your group picked a code freeze date
> yet?  I suspect one bug (or, rather, a non-fatal mis-feature) in the
> Makefile.in recipe for FreeBSD and Solaris, but I'm not certain yet.
> And if there's enough time, I might try adding a few more useful probes.
> (Or someone else might wish to add new ones ... I sent queries to Dustin
> Sallings and Michal Ptaszek this weekend and haven't heard back yet,
> but, well, it *is* the weekend ...)
>
> -Scott
Yes, Deadline for this (and other patches from 'pu' will be next 
Wednesday, so the 30th of November.


There will be a R15A tag pushed to github later today. And I would like 
you to rebase your branch upon that, there is some minor merge conflicts.
Then I will refetch your branch tomorrow.

-- 
/Henrik Nord Erlang/OTP



More information about the erlang-patches mailing list