[erlang-patches] DTrace patch, review draft #3

Henrik Nord <>
Fri Nov 18 11:52:20 CET 2011


On 11/17/2011 08:32 AM, Scott Lystig Fritchie wrote:
> Björn Gustavsson<>  wrote:
>
> bg>  My final comment is that your changes are included in a single
> bg>  commit, which make it harder to review and will it make it harder to
> bg>  understand in the future. I would suggest breaking it up into
> bg>  several commits (at least three): [...]
>
> Björn, I've split the commit from 1 ->  4 pieces.  I've also fixed a few
> bugs and have un-done the DTrace-related edits that I'd put in
> README.md.  Instead, that text has been moved to a new file,
> README.dtrace.md.
>
> I have eliminated all of the OTP test suite failures that I'm aware of,
> though the tests were run this afternoon prior to splitting the commit.
> It's possible that I un-fixed a bugfix, though I think the odds are low.
> I'll be re-running the tests overnight tonight with DTrace unconfigured,
> DTrace configured, and DTrace configured + probes enabled(*).
>
> git clone git://github.com/slfritchie/otp.git dtrace-review3
>
> https://github.com/slfritchie/otp/compare/dtrace-review3
> https://github.com/slfritchie/otp/compare/dtrace-review3.patch
>
> -Scott
>
> (*) I've encountered a odd/weird/buggy? problem with Solaris 10 where
> the Erlang OS process occasionally dumps core due to a SIGTRAP.  I think
> it may have to do with a race condition between starting a new process
> and a turn-them-all-on probe specification.  If anybody happens to know
> (or guess) anything about this, please contact me.
> _______________________________________________
> erlang-patches mailing list
> 
> http://erlang.org/mailman/listinfo/erlang-patches
I added this version to 'pu' yesterday for testing

-- 
/Henrik Nord Erlang/OTP



More information about the erlang-patches mailing list