[erlang-patches] DTrace patch, review draft #1

Mikael Pettersson mikpe@REDACTED
Tue Nov 8 11:12:57 CET 2011


Scott Lystig Fritchie writes:
 > The efile_drv.c has a work-around for a crazy GCC optimization bug.
 > Thank goodness for Google, I dunno how I would've found a work-around
 > for this silly thing.  Many thanks to Trond Norbye for writing clearly
 > about the problem in a membase Git repo commit message.

If you or Trond believe there is a bug in gcc then _please_ report it
to gcc's bugzilla for proper analysis.  Neither this patch nor Trond's
memcached patch contains enough detail for me to verify the presence
or absence of the alleged bug.

[BTW, your workaround for the bug is itself buggy.  You're causing
signed integer overflow which in turn causes undefined behaviour.
Better make the 'gcc_optimizer_hack' variable unsigned.]

If you don't want to report the bug to gcc's bugzilla, then I can take
care of that _if_ you provide a standalone (self-contained with no
external dependencies except libc) test case that reproduces the bug.

/Mikael



More information about the erlang-patches mailing list