[erlang-patches] Add a proplist() type
Kostis Sagonas
kostis@REDACTED
Mon May 23 17:11:44 CEST 2011
Ryan Zezeski wrote:
> I found it odd the there is no canonical proplist() type defined so this
> is my attempt at adding one.
>
> git fetch git://github.com/rzezeski/otp.git
> <http://github.com/rzezeski/otp.git> add_proplist_type
Ryan,
Your attempt is not OK.
For it to be, the proplist() type should be exported from the proplists
module; i.e. added in the export_type declaration of that module. So, if
your patch is to be accepted and included in OTP, minimally this needs
to be fixed.
I thought that since property() is an exported type from the proplists
module, there is no need to define proplist() since its definition would
be simple. But I think I was wrong: Your patch definitely shows that the
current situation with various different "definitions" of proplist() is
not optimal...
Thanks for noticing this.
Kostis
More information about the erlang-patches
mailing list