[erlang-patches] Fwd: True streaming of AES CTR

Henrik Nord <>
Tue May 10 17:07:48 CEST 2011


On 05/10/2011 04:51 PM, Travis Jensen wrote:
> I haven't heard back from Henrik on this, so am resending to the list.
>
> tj
>
> ---------- Forwarded message ----------
> From: *Travis Jensen* < 
> <mailto:>>
> Date: Fri, May 6, 2011 at 12:58 PM
> Subject: Re: [erlang-patches] True streaming of AES CTR
> To: Henrik Nord < <mailto:>>
>
>
> I'm not sure what's happening here. The code is there, I promise. :) 
>  I just did the following, and everything checked out correctly:
>
> git clone https://github.com/erlang/otp.git .
> git fetch 
> https://github.com/SoftwareMaven/otp.git streaming_crypto_functions
> git checkout pu
> git merge 487ed88cdff77e55273b4c62a60c0203f90bd7b0
>
> That said, I made a new branch and re-committed the files to the new 
> branch.  It should be happily found at:
>
> git fetch https://github.com/SoftwareMaven/otp.git streaming_crypto_funcs
>
> The commit point on that one is 299a2ee97fa5ee82eaeeb150cc88c95110258ba9.
>
> I realize you are into the weekend now, but I'll make sure I'm on top 
> of anything I can be over said weekend. I'll also plan on staying up 
> late on my Sunday (your Monday morning) to cover anything at that point.
>
> Sorry for being such a...git. ;)
>
> tj
>
> On Fri, May 6, 2011 at 2:29 AM, Henrik Nord < 
> <mailto:>> wrote:
>
>     On 05/06/2011 01:57 AM, Travis Jensen wrote:
>>
>>
>>         These tests have started to fail after this branch was
>>         included in 'pu'
>>
>>         crypto_SUITE:hmac_update
>>         crypto_SUITE:rc4_stream_test
>>         crypto_SUITE:rc4_test
>>         crypto_SUITE:smp
>>
>>         The deadline for R14B03 approaches so I will need fixes early
>>         next week if you want this to be included.
>>         Thanks!
>>
>>         Ps
>>         Let me know if you require more info
>>
>>         -- 
>>         /Henrik Nord Erlang/OTP
>>
>>
>>     Hi, Henrik,
>>
>>     I've made an update to my branch that addresses the first 3
>>     (problem as the all() list not referencing the correct functions).
>>
>>     git fetch git://github.com/SoftwareMaven/otp.git
>>     <http://github.com/SoftwareMaven/otp.git> streaming_crypto_functions
>>
>>     The rc4_ failures were a result of emacs substituting special
>>     characters behind my back; I did not modify any code there (I
>>     tell you so you know what I'm changing and what you have to worry
>>     about those changes impacting), so it is reverted to what existed
>>     previous to my commit.
>>
>>     The smp test was failing because it references the rc4_ tests.
>>     I've added my new tests to the smp test as well so they will be
>>     tested in multiple processes.
>>
>>     I'm having a heck of a time getting unit tests running. I am
>>     running them manually using:
>>
>>     lists:map(fun(T) ->
>>                    io:format("~p~n", [T]),
>>                    apply(crypto_SUITE, T, [[]])
>>               end,
>>               crypto_SUITE:all()).
>>
>>     so there is a chance I may be missing something, however, all of
>>     the these did run and there were no errors.
>>
>>     I will continue working on getting the unit tests running
>>     officially. If there are other issues, this is my current #1
>>     priority at work. :)
>>
>>     Thanks.
>>
>>     tj
>>     -- 
>>     *Travis Jensen*
>>     *
>>     *Read the Software Maven @ http://softwaremaven.innerbrane.com/
>>     Read my LinkedIn profile @ http://www.linkedin.com/in/travisjensen
>>     Read my Twitter mumblings @ http://twitter.com/SoftwareMaven
>>     Send me email @ 
>>     <mailto:>
>>
>>     /*What kind of guy calls himself the Software Maven???*/
>>
>     Oo
>     I rechecked you branch, and it looks like you have made something
>     strange with it.
>
>     * Add true streaming AES (CTR) encryption and streaming HMAC
>     operations
>     Is now gone?
>
>     and there are a strange "Merge git://github.com/erlang/otp
>     <http://github.com/erlang/otp> into streaming_crypto_functions"
>     there instread, followed by the 2 commits to scrypto_SUIT.erl
>      Resolve unittest failures for streaming encryption
>      Add streaming AES CTR and HMAC functions to smp test
>
>
>     -- 
>     /Henrik Nord Erlang/OTP
>
>
>
>
> -- 
> *Travis Jensen*
> *
> *Read the Software Maven @ http://softwaremaven.innerbrane.com/
> Read my LinkedIn profile @ http://www.linkedin.com/in/travisjensen
> Read my Twitter mumblings @ http://twitter.com/SoftwareMaven
> Send me email @  <mailto:>
>
> /*What kind of guy calls himself the Software Maven???*/
>
>
>
>
> -- 
> *Travis Jensen*
> *
> *Read the Software Maven @ http://softwaremaven.innerbrane.com/
> Read my LinkedIn profile @ http://www.linkedin.com/in/travisjensen
> Read my Twitter mumblings @ http://twitter.com/SoftwareMaven
> Send me email @  <mailto:>
>
> /*What kind of guy calls himself the Software Maven???*/
>
>
> _______________________________________________
> erlang-patches mailing list
> 
> http://erlang.org/mailman/listinfo/erlang-patches
Hi
Strange, I thought i sent you a reply

Anyways, I refetched the branch and it is currently cooking in 'pu'.
Sofar it looks good, but its only one of the builds that have finished 
from yesterday, If it looks well in the morning I will get someone to 
take a closer look at it.

Thank you for the contribution!

-- 
/Henrik Nord Erlang/OTP

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20110510/504cf2ce/attachment-0001.html>


More information about the erlang-patches mailing list