[erlang-patches] What is the preferred method of submitting patches to the list? [was Re: [PATCH] ei: integer overflow in string/atom encoding]

Raimo Niskanen <>
Wed Jun 8 10:56:41 CEST 2011


On Tue, Jun 07, 2011 at 07:05:10PM +0200, Björn-Egil Dahlberg wrote:
> On 2011-06-07 18:41, Raimo Niskanen wrote:
: :
> >
> >Maybe we should wish for contributors to besides the git fetch command
> >supply a http link to the branch for easier online viewing...
> 
> +1, I would like that.
> 
> >Those who do inline patches correct are welcome to do so, but
> >recommending that as the preferred method would render us lots
> >of corrupt patches due to malicious mail clients and whatnot.
> 
> I think Mikaels point is well taken. For small patches it is much easier 
> to review a patch via mail then on github and discussions on various 
> issues could easily be done in the mail.
> 
> Patch notifications should always carry a 'git fetch' entry at the top 
> of the mail.

Except for correct inline patches, of course...

-- 

/ Raimo Niskanen, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list