On Fri, Jun 03, 2011 at 10:58:57AM -0400, Michael Santos wrote: > + size_t len = strlen(p); > + > + if (len >= INT_MAX) return -1; > return ei_encode_atom_len(buf, index, p, strlen(p)); Redundant strlen is redundant. I'll amend the patch.