[erlang-patches] release_handler_1 improvements

[Siri Hansen]

Hi again, Joe!

Could you please explain a bit about the situation where you discovered this
problem? I agree that the timeout and VM restart is not very good, and it
makes sense to check if the supervisor is suspended. But I'm not really sure
if it is correct to allow the upgrade to continue when this error occurs.
Even if an error message is printed, I guess it could be quite easy to miss
this fact... and the question is if that would be a problem or not? Why is
the supervisor suspended in the first place?

Regards
/siri


2011/8/25 Siri Hansen <erlangsiri@REDACTED>

> Hi Joe - I've just started looking at this. Do you think it would be
> possible to add a test case for it?
> Regards
> /siri
>
>
> 2011/8/24 Joe Williams <joe@REDACTED>
>
>>  Anything I can do regarding this patch? I have happily been running it in
>> production since I submitted it to the list in June.
>>
>> -Joe
>>
>>
>> --
>> Name: Joseph A. Williams
>> Email: joe@REDACTED
>> Blog: http://www.joeandmotorboat.com/
>> Twitter: http://twitter.com/williamsjoe
>>
>> On Wednesday, July 6, 2011 at 3:43 PM, Joe Williams wrote:
>>
>>  Anything I can do to help this patch graduate?
>>
>> Thanks!
>>
>> -Joe
>>
>>
>> --
>> Name: Joseph A. Williams
>> Email: joe@REDACTED
>> Blog: http://www.joeandmotorboat.com/
>> Twitter: http://twitter.com/williamsjoe
>>
>> On Tuesday, June 14, 2011 at 12:26 PM, Joe Williams wrote:
>>
>>  Updated this branch, please refetch.
>>
>> git fetch git://github.com/joewilliams/otp.git release_handler_1
>>
>>
>> --
>> Name: Joseph A. Williams
>> Email: joe@REDACTED
>> Blog: http://www.joeandmotorboat.com/
>> Twitter: http://twitter.com/williamsjoe
>>
>> On Friday, June 10, 2011 at 8:52 AM, Joe Williams wrote:
>>
>>  Great, thanks!
>>
>>
>> --
>> Name: Joseph A. Williams
>> Email: joe@REDACTED
>> Blog: http://www.joeandmotorboat.com/
>> Twitter: http://twitter.com/williamsjoe
>>
>> On Friday, June 10, 2011 at 8:51 AM, Raimo Niskanen wrote:
>>
>> On Thu, Jun 09, 2011 at 08:20:51AM -0700, Joe Williams wrote:
>>
>> Please fetch:
>>
>> git fetch git://github.com/joewilliams/otp.git release_handler_1
>>
>> This is a different branch with a better commit message and no white space
>> changes.
>>
>>
>> Excellent. I will include your patch in 'pu' after rewording the
>> summary line to imperative form.
>>
>>
>>
>>
>> --
>> Name: Joseph A. Williams
>> Email: joe@REDACTED
>> Blog: http://www.joeandmotorboat.com/
>> Twitter: http://twitter.com/williamsjoe
>>
>>
>> On Thursday, June 9, 2011 at 7:44 AM, Joe Williams wrote:
>>
>> Nothing specific, just wondered if anyone had any thoughts on how I dealt
>> with a couple of corner cases in installing releases.
>>
>> I'll fix things up and get back shortly.
>>
>> --
>> Name: Joseph A. Williams
>> Email: joe@REDACTED (mailto:joe@REDACTED <joe@REDACTED>)
>> Blog: http://www.joeandmotorboat.com/
>> Twitter: http://twitter.com/williamsjoe
>>
>>
>> On Thursday, June 9, 2011 at 12:11 AM, Raimo Niskanen wrote:
>>
>> On Wed, Jun 08, 2011 at 03:41:37PM -0700, Joe Williams wrote:
>>
>> Any thoughts/feedback on this patch? I realize it doesn't follow the
>> guidelines (https://github.com/erlang/otp/wiki/Submitting-patches)
>> exactly and will clean it up soon.
>>
>>
>> Anything in particular? I just got caught up in tideous merge work
>> yesterday and missed to include your patch in 'pu', I was about
>> to take it now.
>>
>> But if you have a cleanup I can wait for it...
>>
>>
>>
>> --
>> Name: Joseph A. Williams
>> Email: joe@REDACTED (mailto:joe@REDACTED <joe@REDACTED>)
>> Blog: http://www.joeandmotorboat.com/
>> Twitter: http://twitter.com/williamsjoe
>>
>>
>> On Tuesday, June 7, 2011 at 2:33 PM, Joe Williams wrote:
>>
>> git fetch git://github.com/joewilliams/otp.git (
>> http://github.com/joewilliams/otp.git) (
>> http://github.com/joewilliams/otp.git) release_handler
>>
>>
>> _______________________________________________
>> erlang-patches mailing list
>> erlang-patches@REDACTED (mailto:erlang-patches@REDACTED<erlang-patches@REDACTED>
>> )
>> http://erlang.org/mailman/listinfo/erlang-patches
>>
>>
>>
>> --
>>
>> / Raimo Niskanen, Erlang/OTP, Ericsson AB
>>
>>
>> _______________________________________________
>> erlang-patches mailing list
>> erlang-patches@REDACTED (mailto:erlang-patches@REDACTED<erlang-patches@REDACTED>
>> )
>> http://erlang.org/mailman/listinfo/erlang-patches
>>
>>
>> --
>>
>> / Raimo Niskanen, Erlang/OTP, Ericsson AB
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>> erlang-patches mailing list
>> erlang-patches@REDACTED
>> http://erlang.org/mailman/listinfo/erlang-patches
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20110825/246b9798/attachment.htm>