[erlang-patches] Re: [PATCH] file: fix hang reading compressed files
Michael Santos
michael.santos@REDACTED
Thu Apr 7 14:42:12 CEST 2011
On Thu, Apr 07, 2011 at 10:30:41AM +0200, Henrik Nord wrote:
> Hi
> Your patch has come up with feedback
>
>
>
> The fix looks OK, but the name 'offset' is confusing since there is
> another 'offset' also in context. Rename to e.g 'save_pos':
I missed that, yes it is confusing! I've re-sent the patch, thanks for
the feedback!
More information about the erlang-patches
mailing list