[erlang-patches] epp_dodge:tokens_to_string/1 crash

Tuncer Ayaz <>
Fri Sep 24 13:50:29 CEST 2010


On Fri, Sep 24, 2010 at 1:24 PM, Maria Christakis wrote:
> Hello,
>
> When run on the attached file (that contains a syntax error) the
> epp_dodge:quick_parse_file/1 function crashes. This happens because
> the epp_dodge:tokens_to_string/1 function does not have a clause for
> characters. I have fixed this bug in the following patch:
>
> git fetch git://github.com/kostis/otp.git tokens_to_string_crash

Just a minor commit message nitpick following
http://github.com/erlang/otp/wiki/Writing-good-commit-messages. Good
rules are a 50 chars summary line without terminating dot and a 70
chars wrapped description. The blank line after the summary is only
needed if you write a description.

Before:
-----8<-----
Add a function clause in the epp_dodger:tokens_to_string/1
function to avoid a crash in case the argument is a character
----->8-----

After:
-----8<-----
Fix crash in epp_dodger:tokens_to_string/1

Add a function clause in the epp_dodger:tokens_to_string/1 to
avoid a crash in case the argument is a character.
----->8-----


More information about the erlang-patches mailing list