[erlang-patches] gen_stream updated to test worker process links

[Raimo Niskanen]

On Thu, Sep 16, 2010 at 08:59:57AM +0200, Raimo Niskanen wrote:
> On Wed, Sep 15, 2010 at 11:07:56PM -0700, jay@REDACTED wrote:
> > > On Mon, Sep 6, 2010 at 7:50 PM,  <jay@REDACTED> wrote:
> > >
> > >> Let me know if the tests perform better on your environment.
> > >> Hopefully, this will solve the intermittent failures on
> > >> other platforms.
> > >
> > > There were no failures in any of the gen_stream test cases
> > > tonight, but since the failures were intermittent we'll have to
> > > wait a few more days to be sure.
> > 
> > Have the tests continued to run without failure?
> 
> Yes. That looks fine.
> 
> > 
> > >
> > > The shell_SUITE:start_restricted_from_shell/1 test case,
> > > however, still fails.
> > >
> > 
> > The current version of gen_stream contains %% DEBUG statements
> > at the end of each gen_stream test case which invoke the equivalent
> > failing shell_SUITE command.  If you could remove the DEBUG
> > comments and run the tests, hopefully, we can isolate the test
> > case which is causing the shell_SUITE failure.  Since I cannot
> > reproduce the problem, I am dependent on any information you
> > can provide about the test gen_stream_SUITE running on your
> > environment.
> 
> Ok. We will try that any day...

Removing "%DEBUG: " causes all tests to fail with (or similar):

=== Ended at 2010-09-16 09:21:36
=== location {gen_stream_SUITE,75}
=== reason = no function clause matching 
                 erl_scan:tokens1(<0.59.0>,
                                  {erl_scan,#Fun,false,
                                      false,false},
                                  1,no_col,[],#Fun,[])
  in function  gen_stream_SUITE:scan/2
  in call from gen_stream_SUITE:start_bin/1
  in call from test_server:my_apply/3
  in call from test_server:ts_tc/3
  in call from test_server:run_test_case_eval1/6
  in call from test_server:run_test_case_eval/8

It seems erl_scan:tokens gets called with
([], pid(), 1) from gen_stream_SUITE:scan/2 when the second argument
according to the manual should be string()|eof, not pid().

> 
> > 
> > Thanks for your efforts,
> > jay
> > 
> > 
> > 
> > ________________________________________________________________
> > erlang-patches (at) erlang.org mailing list.
> > See http://www.erlang.org/faq.html
> > To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED
> 
> -- 
> 
> / Raimo Niskanen, Erlang/OTP, Ericsson AB
> 
> ________________________________________________________________
> erlang-patches (at) erlang.org mailing list.
> See http://www.erlang.org/faq.html
> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED

-- 

/ Raimo Niskanen, Erlang/OTP, Ericsson AB