[erlang-patches] Fix hibernate with HiPE

Mikael Pettersson <>
Sun Oct 10 23:25:51 CEST 2010


Paul Guyot writes:
 > 
 > Le 10 oct. 2010 à 19:32, Mikael Pettersson a écrit :
 > 
 > > Looking at the patch via github's awful web interface it looks like
 > > it will cause the 'is_recursive' variable to be conditionally defined
 > > and possibly used uninitialized (at least as far as GCC will be able
 > > to tell).  Thus, NAK for now.
 > > 
 > > I would have provided the fix but you didn't include the patch in the
 > > email so I can't.
 > 
 > Mikael,
 > 
 > Thank you for your e-mail and review. While the is_recursive variable will currently not be used uninitialized (if stack is emptied by erts_garbage_collect_hibernate, status is set to P_WAITING), I agree this is a mistake and I have amended the patch accordingly. It is now available here:
 > 
 > http://github.com/pguyot/otp/commit/75e39faaa3180a78e8dab8d7bd4bef066dae579b

This version is Ok.


More information about the erlang-patches mailing list