[erlang-patches] Change to allow table viewer to display refs, ports and small binaries

Björn Gustavsson <>
Thu Oct 7 15:53:05 CEST 2010


On Wed, Oct 6, 2010 at 10:02 PM, Blaine Whittle <> wrote:
> Trivial formatting change that improves the usability of tv.
>
> Table viewer displayed #Port, #Ref, or #Bin as place holders for their
> respective object types in ets and mnesia tables.  This can make table
> viewer difficult to use when viewing tables containing those data types.
> It doesn't make sense to render large binaries so #Bin will still be
> used for binaries that exceed 100 bytes.
>
> git fetch git://github.com/bwhittle/otp.git tv_render_fix
>

Thanks! I will include it in with the following line:

write(Term, _D) when is_binary(Term) andalso size(Term) > 100 -> "#Bin";

changed to:

write(Term, _D) when is_binary(Term), byte_size(Term) > 100 -> "#Bin";

(Coding style)

Points to ponder:

Wouldn't it be more useful to truncate long binaries and end
them with "..."?

Shouldn't bitstrings also be handled?

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list