[erlang-patches] [PATCH] error_handler: add no_native compiler directive

Björn Gustavsson bgustavsson@REDACTED
Tue Oct 5 14:33:54 CEST 2010


On Mon, Oct 4, 2010 at 11:34 PM, Tuncer Ayaz <tuncer.ayaz@REDACTED> wrote:
> As suggested by Mikael Pettersson:
> "I agree there _may_ be a recursion between the native-traps-to-beam
> mechanism and the error_handler module. However, the real problem is
> that the chosen mechanism (point to target MFA's BEAM code) isn't
> flexible enough to handle newer features like on_load or (apparently)
> a native-mode error_handler.
>
> My planned fix is to make remote calls link to the target's Export*
> instead, just like BEAM does, which should solve the problems. This
> will however require HiPE to use different kinds of trap-to-beam stubs
> for remote and local calls, since local calls must not and often
> cannot go via Export entries.
>
> A simpler workaround for the error_handler issue (which I couldn't
> reproduce) is to just never compile error_handler to native code. It's
> not like there's a lot to gain by doing that. Please try the patch
> below."
>
> Patch has been tested and confirmed to make --enable-native-libs
> useable.
>
> Signed-off-by: Mikael Pettersson <mikpe@REDACTED>
> Acked-by: Tuncer Ayaz <tuncer.ayaz@REDACTED>

Thanks! Will include in pu.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list