[erlang-patches] patch: emacs flymake support

Raimo Niskanen <>
Tue May 25 10:51:50 CEST 2010


Hi.

A few doubts about your contribusion:
* The added files are missing from the Makefile. Can you
  please fix this?
* flymaker.sh is a bash script and we have Solaris 8 on our
  list of supported platforms, so a /bin/sh script would
  be more portable. This will not not stop us from accepting
  your contribution, but is there anything bash specific
  in the script? A quick readthrough only revealed some
  '==' tests that is portably written as '=', but I saw
  no essential bash features used.
* Could even flymaker.sh be an escript? That might even
  make it work on Windows.

On Mon, May 17, 2010 at 07:53:47AM -0700, Dave Peticolas wrote:
> On 05/17/2010 06:24 AM, Raimo Niskanen wrote:
> >On Sat, May 15, 2010 at 11:01:34PM -0700, Dave Peticolas wrote:
> >   
> >>This patch adds (optional) support for flymake mode
> >>(on-the-fly syntax checking) on Emacs, for UNIX systems.
> >>
> >>This work was originally submitted to the Erlware version
> >>of the Emacs mode by Mats Cronqvist.
> >>
> >>   http://github.com/jdavisp3/otp/tree/emacs-flymake
> >>     
> >Thanks. Included in 'pu' with minor tweaks of the commit message
> >and whitespace fixes.
> >
> >For future contributions please use the recommended
> >source format e.g:
> >     git fetch git://github.com/jdavisp3/otp.git emacs-flymake
> >   
> 
> Will do, thanks!
> 
> dave

-- 

/ Raimo Niskanen, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list