[erlang-patches] Montavista system call error handling patch

Björn Gustavsson <>
Tue May 18 15:18:34 CEST 2010


2010/5/15 Björn Gustavsson <>:
> 2010/5/14 Steve Vinoski <>:
>>
>> Good point. I've amended my commit to include this information.
>
> Excellent! Included in 'pu'.

Unfortunately this new version does not build:

drivers/common/inet_drv.c: In function ‘inet_fill_opts’:
drivers/common/inet_drv.c:5646: error: ‘SOCKET_ERROR’ undeclared
(first use in this function)
drivers/common/inet_drv.c:5646: error: (Each undeclared identifier is
reported only once
drivers/common/inet_drv.c:5646: error: for each function it appears in.)

The build problem exposes a place where the new IS_SOCKET_ERROR()
macro is not used.

Another thing is that the Windows version of the macro should still
use SOCKET_ERROR:

#define IS_SOCKET_ERROR(val) ((val) == SOCKET_ERROR)

since SOCKET_ERROR is defined in a header file on Windows.

Because of the build error, Raimo has taken out the branch
from the pu branch. He will re-instate it as soon as you have
fixed the build problem.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list