[erlang-patches] Re: Two printf format fixes
Tue Mar 2 10:20:55 CET 2010
On Tue, Mar 2, 2010 at 8:32 AM, Martti Kuparinen
> I'm resending this as inline patch (instead of an attachment)...
We do accept inlined patches if they are generated using "git format-patch"
(or formatted in the same way). Basically that means that the subject
and body (up to a "---" delimiter) will be the commit message and From
address of the email will be taken as the author. Such patches are
easily committed to the git repository using "git am -3".
The reason we are being particular about the format of patches
is that we now are doing a serious effort to keep up with the flow
of incoming patches, and either accept or reject them with a good
reason (in the past, most patches with issues were simply ignored).
We may eventually take care of patches that don't follows our guidelines
(especially if they correct serious bugs), but you will definitely have
to wait longer for a response.
Over to the patch itself:
> - fprintf(stderr, "esock_malloc: cannot alloc %d bytes\n", size);
> + fprintf(stderr, "esock_malloc: cannot alloc %zu bytes\n", size);
As far as I know, the "z" specifier is not portable. For
instance, I did not find it described in Microsoft's manual page
Björn Gustavsson, Erlang/OTP, Ericsson AB
More information about the erlang-patches