[erlang-patches] format_status analog for error_info

[Steve Vinoski]

On Mon, Mar 1, 2010 at 1:16 PM, Andrew Thompson <andrew@REDACTED> wrote:

> On Sun, Feb 28, 2010 at 01:13:37AM -0500, Steve Vinoski wrote:
> > This patch is ready:
> >
> > git fetch git://github.com/vinoski/otp.git format_status_error_info
> >
> > Since gen_event did not previously have format_status callback support, I
> > made these changes in two commits: the first to add termination support
> to
> > existing format_status support in gen_fsm and gen_server along with doc
> and
> > unit tests, and the second commit to add the format_status callback
> support
> > to gen_event along with related doc and unit tests.
> >
>
> The patch looks good to me, except that I *think* (github makes it hard
> to tell) that the indenting on line 545 of gen_fsm.erl is wrong
> (FmtStateData = .. end should line up with the call to error_info).
>

Thanks for checking. Because the FmtStateData = ... is a continuation over
multiple lines, the second and subsequent lines are indented a little beyond
the initial line, which I think is correct. I'm using a fairly recent emacs
erlang-mode without modification or specialization, so I assume it's
indenting correctly.


> The documentation changes look good too. Thanks for your work on this.
>

Sure, and thanks for proposing the idea in the first place.

--steve