[erlang-patches] patch: Allow a user_defined function to wrap mnesia_schema:merge_schema()

[Ulf Wiger]

git fetch git://github.com/uwiger/otp.git schema_merge

"remove debug printout and accidental variable name reuse"

http://github.com/uwiger/otp/commit/b4844311746b44e85aa49d6e7bd68703301998e0


Thanks Fredrik Thulin for helping me figure out what I did wrong.

BR,
Ulf W


On 06/01/2010 05:57 PM, Raimo Niskanen wrote:
> On Tue, Jun 01, 2010 at 04:19:36PM +0200, Ulf Wiger wrote:
>>
>> What is the easiest way to address it?
>>
>> The debug printout:
>> Line 2663 in 
>> http://github.com/erlang/otp/blob/pu/lib/mnesia/src/mnesia_schema.erl
>> should be deleted (I've not seen any other debug printouts)
>>
>> The crash:
>> Line 2676, 2679 - rename NewNodes to something else, e.g. OtherNodes.
>>
>> I could resubmit, but my git fu is still low enough that I'm
>> likely to make a mess of things without detailed instructions. :)
> 
> The easiest for you (and for us to follow) would be to
> just keep on working on the same branch:
> 
> In your local repository (from which you pushed the local branch
> schema_merge) to your github repository 'origin' (assumed).
> 
> $ git checkout schema_merge
> 
> Do the changes above.
> Test it.
> 
> $ git push origin schema_merge
> 
> Send a mail to erlang-patches saying you have new commits
> available with:
> 
>   git fetch git://github.com/uwiger/otp.git schema_merge
> 
>>
>> I have done the above and tested with four nodes (it did in fact
>> crash before; now it doesn't).
>>
>> BR,
>> Ulf W
>>
>> Dan Gudmundsson wrote:
>>> There are debug printouts left.
>>> Starting a cluster of more than 2 nodes (i.e. 3) crashes for me.
>>>
>>> /Dan
>>>
>>> 2010/5/10 Björn Gustavsson <bgustavsson@REDACTED>:
>>>> On Sun, May 9, 2010 at 11:40 AM, Ulf Wiger
>>>> <ulf.wiger@REDACTED> wrote:
>>>>> http://github.com/uwiger/otp/tree/schema_merge
>>>> Thanks! Will include in 'pu'.
>>>>
>>>> For future contributions, please also include a "git fetch" line in
>>>> the email that I can
>>>> copy/paste into the shell. For instance:
>>>>
>>>> git fetch git://github.com/uwiger/otp.git schema_merge
>>>>
>>>> --
>>>> Björn Gustavsson, Erlang/OTP, Ericsson AB
>>>>
>>>> ________________________________________________________________
>>>> erlang-patches (at) erlang.org mailing list.
>>>> See http://www.erlang.org/faq.html
>>>> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED
>>>>
>>>>
>>
>>
>> -- 
>> Ulf Wiger
>> CTO, Erlang Solutions Ltd, formerly Erlang Training & Consulting Ltd
>> http://www.erlang-solutions.com
>>
>> ---------------------------------------------------
>>
>> ---------------------------------------------------
>>
>> WE'VE CHANGED NAMES!
>>
>> Since January 1st 2010 Erlang Training and Consulting Ltd. has become 
>> ERLANG SOLUTIONS LTD.
>>
>> www.erlang-solutions.com
>>
>>
>> ________________________________________________________________
>> erlang-patches (at) erlang.org mailing list.
>> See http://www.erlang.org/faq.html
>> To unsubscribe; mailto:erlang-patches-unsubscribe@REDACTED
>>
> 

---------------------------------------------------

---------------------------------------------------

WE'VE CHANGED NAMES!

Since January 1st 2010 Erlang Training and Consulting Ltd. has become ERLANG SOLUTIONS LTD.

www.erlang-solutions.com