[erlang-patches] tid() is not a predefined type anymore

Raimo Niskanen <>
Tue Jun 1 10:18:51 CEST 2010


On Mon, May 31, 2010 at 05:43:12PM +0300, Kostis Sagonas wrote:
> Raimo Niskanen wrote:
> >On Fri, May 28, 2010 at 02:56:31PM +0300, Kostis Sagonas wrote:
> >>There is a patch that removes tid() from the list of predefined types.
> >>It can be included as is provided that the 'export_type' branch is first 
> >>included in OTP.  Otherwise, one has to manually remove the line which 
> >>reads:
> >>
> >>-export_type([tab/0, tid/0]).
> >>
> >>from file ets.erl
> >>
> >>
> >>	git fetch git://github.com/kostis/otp.git ets-tid-type
> >
> >I got into merge conflicts due to the bootstrap code
> >update and more. I will have to take this tomorrow...
> 
> Raimo,
> 
> The erl_lint.beam file in bootstrap is nothing special. It is just the 
> .beam file that corresponds to the erl_lint.erl file so any such .beam 
> file will do.
> 
> The only thing that you have to be careful of is to include such a file 
> before including the change in lib/debugger/src/dbg_iload.erl

Yes. That I can handle and/or ask Björn.
This is trickier:

@@@ -46,7 -49,7 +49,11 @@@ load_mod(Mod, File, Binary, Db) -
  	    What
      end.
  
++<<<<<<< HEAD
 +-spec load_mod1(module(), file:filename(), binary(), tid()) -> no_return().
++=======
+ -spec load_mod1(atom(), file:filename(), binary(), ets:tid()) -> no_return().
++>>>>>>> ks/ets-tid-type
  
  load_mod1(Mod, File, Binary, Db) ->
      store_module(Mod, File, Binary, Db),

In your new branch ks/ets-tid-type you use atom() instead of module()
that was added by ks/cleanups as suggested by tidier. I know that
the tid() -> ets:tid() change is expected buth the module() -> atom()
is not my home turf...

> 
> Kostis

-- 

/ Raimo Niskanen, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list