[erlang-patches] load native code for early modules

Paul Guyot <>
Wed Jul 28 10:41:36 CEST 2010


Le 28 juil. 2010 à 09:03, Björn Gustavsson a écrit :

> Your added code is located in the code_server module,
> but it is not executed in the code_server process.
> 
> This is confusing for both human readers and a test
> case called code_SUITE:ext_mod_dep/1 which attempts
> to find unsafe calls in the code_server process.
> 
> Therefore, I suggest that you move the code to the 'code'
> module (putting the call to load_native_code_for_all_loaded/0
> in the do_start/1 function).
> 
> Minor style nit: You don't need parenthesis around a catch
> unless you want to assign the result to a variable.

Thank you for the review!

I have just committed suggested changes here:
http://github.com/pguyot/otp/commit/a30b889c01cb8cc9e0ad021f41b7ed27cf97fed7

I also added a non-regression test:
http://github.com/pguyot/otp/commit/5f23082a8d842ca0a414748e011c4b10240c8fcc

Paul
-- 
Semiocast                    http://semiocast.com/
+33.175000290 - 62 bis rue Gay-Lussac, 75005 Paris



More information about the erlang-patches mailing list