[erlang-patches] patch: common_test include vs. include_lib

[Fred Hebert]

On Thu, Jan 14, 2010 at 9:46 AM, Peter Andersson <peppe@REDACTED>wrote:

> Hi Fred,
>
> Thanks for the fix!
>
> Problem is that for this to work (to use include_lib instead of include
> in ct.hrl), test_server and common_test must be included in the
> bootstrap compiler, or we fail to build common_test for our nightly
> tests. That said, I agree it's a lot nicer to use include_lib so that
> test suites can be manually compiled with the hassle of specifying
> include paths to test_server and common_test. Therefore we've decided to
> modify the bootstrap compiler and include your fix as soon as possible.
>
> Actually, we have looked into changing this before. But since test suite
> compilation is performed automatically by common_test, and because of
> the problem mentioned above, we never prioritized it. But like I said,
> we do realize the benefit of being able to compile test suites manually
> without invoking common_test, and since you take the time now to send us
> this patch, we'll finally do something about it.
>
> Best regards,
> Peter
>
> Erlang/OTP, Ericsson AB
>
> Oh, alright, thanks for the explanation. I had seen that the branch did not
graduate because of build problems with the bootstrap compiler, but not
knowing the Erlang process for that kind of stuff, I was at a loss on how to
fix this. Thanks guys, it's going to be helpful, especially on Windows,
where the install procedure is a bit vague from the quick searches I've done
(I instead created my own ct.hrl to deal with this in my personal projects).