[erlang-patches] spawn to rpc, filter, etc.

Björn Gustavsson <>
Thu Feb 25 09:02:07 CET 2010


Thinks!

On Sun, Feb 21, 2010 at 11:13 AM,  <> wrote:
> git fetch git://github.com/bile/otp.git spawn_rpc

This patch touches very sensitive code paths that should
not be changed lightly. Therefore, we'll need very good
commit messages and some clarifications before I will
consider including it even in 'pu'.

Have you run the kernel test suite?

Your first commit message starts with:

"Move spawn/4 to rpc, add filter"

which is a clear sign that the commit should be split
into two commits using "git add -p".

The first commit should do the moving of the
spawn/4 functions and the commit message should
give a very good reason why that is useful and/or
which problem it solves.

Also, what will happen if an Erlang node with the
new code communicates with an older Erlang node
running R13B04?

The next commit says:

"Add forward compatibilities to net_kernel with regard to spawn/4"

I don't understand what you mean with forward compatibility.
What kind of change do you plan in the future?

Or do you mean backward compatibility, and should this change
be squeezed into the commit that moves the spawn/4 functions?

Another minor issue: this commit introduce compilation warnings
for unused variables.

> git fetch git://github.com/bile/otp.git net_kernel_catchall
> git fetch git://github.com/bile/otp.git kernel_stops

Will include in 'pu'.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list