[erlang-patches] Improvements in the Report Browser

[Alvaro Videla]

I just pushed the changes here:

http://github.com/videlalvaro/otp/tree/va/rb-improvements

Thanks for the feedback,

Alvaro


On Feb 2, 2010, at 6:38 PM, Björn Gustavsson wrote:

> 2010/1/4 Björn Gustavsson <bgustavsson@REDACTED>:
>> On Fri, Dec 25, 2009 at 10:03 AM, Videla Alvaro <videlalvaro@REDACTED> wrote:
>> 
>>> http://github.com/videlalvaro/otp/tree/va/rb-improvements
>> 
>> Thanks! Included in 'pu'.
> 
> We have now reviewed this patch. In order to include it in the next release,
> the following changes must be made:
> 
> * There is no need for a new function to replace rb:grep/1. Since rb:grep/1 is
> (usually) used manually to browse reports, the minor potential incompatibility
> introduced by changing the regular expression engine is acceptable even in
> a minor release. Therefore, rb:grep/1 should be changed to use the re module.
> 
> * It must not be a requirement to pass a compiled regular expression. rb:grep/1
> should still accept a string, and automatically compile it. It could
> also optionally
> allow a compiled regular expression. (The new rb:filter/1 function should work
> in the same way.)
> 
> -- 
> Björn Gustavsson, Erlang/OTP, Ericsson AB