[erlang-patches] a patch for "OldHeap unsed"

Björn Gustavsson bgustavsson@REDACTED
Thu Apr 8 09:54:17 CEST 2010


On Thu, Apr 8, 2010 at 5:48 AM, satoshi kinoshita <kino@REDACTED> wrote:

> system_info(procs) is currently reporting a same value for both
> "OldHeap" and "OldHeap unsed".
> This is a patch for erts/emulator/beam/break.c to report
> "OLD_HEND(p) - OLD_HTOP(p)"
> instead of
> "OLD_HEND(p) - OLD_HEAP(p)"
> for "OldHeap unsed".
>
> git fetch git://github.com/kinogmt/otp.git old_heap_unused
>

Thanks! The patch itself looks good, but we would prefer
to have a complete author name. Is OK to change the
author identification to "Satoshi Kinoshito <kino@REDACTED>"?

Also, I would like more information in the commit message,
for instance like this:

    system_info(procs): Fix the value for "OldHeap unused"

    The value for "OldHeap unused" in the output of
    erlang:system_info(procs) and in crash dumps, was incorrectly
    calculated as the size of the entire old heap.

If you approve the changes above, I can do the changes for you.
You don't have to re-submit the patch.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list