[erlang-patches] Patch to fix ssh library

Kris Rasmussen <>
Fri Nov 20 05:43:42 CET 2009


Hi Niclas,

I'm glad to hear that. Is there somewhere I can look to see the SSH-1.1.7
code?

I've also made a patch to enable customizing the way SSH keys are looked up
with a callback module and am currently looking into giving ssh channel
modules more control over the SSH window size. I'd like to know if some of
this work is already being done.

Thanks!

Kris

On Thu, Nov 19, 2009 at 12:44 AM, Niclas Eklund <>wrote:

>
> Hello!
>
> Thanks for the patch! This issue has already been solved in a slightly
> different way in SSH-1.1.7, which will be included in R13B03.
>
> Best regards,
>
> /Niclas @ Erlang/OTP
>
>
> On Wed, 18 Nov 2009, Kris Rasmussen wrote:
>
>  I was noticing that when receiving large amounts of data the erlang SSH
>> library would often freeze and no longer receive any data from the server
>> I
>> was connecting to. After a bit of work, I tracked this down to an
>> "infinite"
>> loop in ssh_connection_handler.erl. The problem occurs when the first
>> block
>> has not yet been decoded and a call to next_packet is made. This would
>> trigger the process to send itself a socket-receive message but it's
>> possible that there isn't additional data ready on the socket. I fixed
>> this
>> by adding a call to make the socket active again as is the case in the
>> subsequent next_packet function definition when the decoded_data_buffer is
>> not empty.
>>
>>  From my testing so far, this resolves the issue and I have not yet seen
>>> any
>>>
>> other side effects. Please let me know what you think.
>>
>> I've attached my patch for R13B02, but you can also get it here:
>>
>> http://github.com/krisr/erlang-macports/raw/master/lang/erlang/files/patch-lib-ssh-src-ssh_connection_handler.erl.diff
>>
>> Best,
>> Kris
>>
>> --
>> Kris Rasmussen
>> 
>>
>> Twitter: http://twitter.com/aptana
>> Facebook: http://aptana.com/facebook
>>
>>
>
>


-- 
Kris Rasmussen


Twitter: http://twitter.com/aptana
Facebook: http://aptana.com/facebook


More information about the erlang-patches mailing list