[erlang-patches] Treat warnings as errors in compile

christopher faulet <>
Tue Dec 15 17:29:13 CET 2009


Björn Gustavsson wrote:
> On Tue, Dec 15, 2009 at 10:13 AM, christopher faulet
> <> wrote:
>> I added the flag 'warnings_as_errors' in compile.erl. With this flag,
>> warnings are treated as errors, like gcc flag '-Werror'.
>>
>> git fetch git://github.com/capflam/otp.git compile_warning_as_error
> 
> Thanks! Included in 'pu', but I have separated out the whitespace changes
> into a separate commit to make the diff of your commit easier to read.
> 
> While I recommend making sure that no *new* trailing whitespace is added
> by a patch, taking out *existing* trailing whitespace should be done in a
> separate commit if it is to be done at all. And whitespace should never
> be removed from the header, because it will only be added back
> again by a trigger when the patch is graduated to the development
> branch in Clearcase.
> 

Björn,

Thanks for your work and your feedback.

On Jean-Sébastien pédron suggestion, I updated my patch to add the
option -Werror in erlc.

-- 
Christopher Faulet

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20091215/85d310ba/attachment.bin>


More information about the erlang-patches mailing list