[erlang-patches] Add support for dependencies Makefile

Jean-Sébastien Pédron jean-sebastien.pedron@REDACTED
Tue Dec 15 00:35:06 CET 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Björn Gustavsson wrote:
| I have squashed your branch into one commit, retaining the commit
| message from the first commit, because your branch contains 4 commits
| and a merge without any good reason.

I'm new to git. I tried to fix the commit message of the 3rd commit by
using git commit --amend, but failed to do so properly :)

| If that is OK for you, you can base your further work on that
| version.

Thank you for the feedback, I'll take a look at your cleanup tomorrow.

| The code style needs some work before we can consider including it in
| Erlang/OTP. Here are the major things I saw when glancing at your
| code:

Should I make a new branch from your 'pu' branch and use it to fix the
style issues?

- --
Jean-Sébastien Pédron
http://www.dumbbell.fr/

PGP Key: http://www.dumbbell.fr/pgp/pubkey.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksmy6oACgkQa+xGJsFYOlPY1wCgrQLVcmElmcO/reCrpqXq+hic
kjoAoMA2xtCYlJK3Kbm9ZVlJ9/AP3FYm
=m0K3
-----END PGP SIGNATURE-----


More information about the erlang-patches mailing list