[erlang-patches] Re: Fix for c:nc

Björn Gustavsson bgustavsson@REDACTED
Sun Dec 13 09:56:50 CET 2009


2009/12/12 Björn Gustavsson <bgustavsson@REDACTED>:
> On Sat, Dec 12, 2009 at 7:55 PM, Alex Suraci <i.am@REDACTED> wrote:
>> I have amended my commit to fix both the patch itself (concat -> filename:join, and now the objfile is correctly determined).
>>
>> I have also added testcases for c:nc to the c_SUITE, mirroring the normal tests for c:c.
>>
>> git fetch git://github.com/vito/otp.git cncfix
>
> Thanks! I have included your new version in 'pu'.

Now that there are test cases, I have looked at the
code properly for the first time and fixed a few style
issues in a separate commit. I intend to squash that
commit into your commit (you will retain authorship)
before merging the branch into the development branch.

Here is my fix-up commit:

http://github.com/erlang/otp/commit/0b2f209c6c1414f823ffbf34d03fc19156284a1a

If you see any problems with this, speak up as soon
as possible, because I plan to merge your branch
within a few days.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list