[erlang-patches] Patch: Add Blowfish ECB, CBC and OFB modes

Björn Gustavsson <>
Thu Dec 3 14:13:47 CET 2009


On Thu, Dec 3, 2009 at 1:26 PM, Paul Oliver <> wrote:
> My patch that was accepted into R13B02 only implemented CFB64 mode.
> This branch consists of two patches.  One implements the remaining
> Blowfish modes, which are supported by all versions of OpenSSL.  The
> second adds a crypto test suite with a blowfish batch.
>
> git fetch git://github.com/puzza007/otp.git blowfish_ecb_cbc_ofb
>

Thanks! Included in the 'pu' branch.

And a special thanks for writing test cases.

There are few minor issues that I would like have corrected. I can fix
them for you, if it's OK for you:

1) Consistent user name. Can you set up your config files so that
you always have the same user name and email (that part I can't
help you with :) Is "Paul Oliver <>" what you
would prefer? In that case I can fix that in the branches you have
submitted so far.

2) Using shorter lines in the commit message (it is difficult to read
in gitk). I can fix that for you.

3) It seems that the gist and the test suite contains the same
test code, so perhaps the link to the gist is not necessary in
the commit comment? If you agree I can fix that for you, otherwise
the link can stay.

-- 
Björn Gustavsson, Erlang/OTP, Ericsson AB


More information about the erlang-patches mailing list