Build system ignores LDFLAGS

[Davide Pesavento]

On Mon, Apr 20, 2009 at 14:30, Raimo
Niskanen<raimo+erlang-bugs@REDACTED> wrote:
> On Fri, Apr 17, 2009 at 11:34:49PM +0200, Davide Pesavento wrote:
>> On Sat, Apr 4, 2009 at 13:05, Davide Pesavento <davidepesa@REDACTED> wrote:
>> > On Tue, Mar 31, 2009 at 22:13, Davide Pesavento <davidepesa@REDACTED> wrote:
>> >> Hello,
>> >>
>> >> Erlang's build system seems to ignore custom LDFLAGS. This is the QA
>> >> warning shown by Portage (Gentoo Linux's package manager) after
>> >> building R12B-5 with LDFLAGS="-Wl,-O1 -Wl,--as-needed
>> >> -Wl,--hash-style=gnu"
>> >>
>> >> QA Notice: Files built without respecting LDFLAGS have been detected
>> >>  Please include the following list of files in your report:
>> >> /usr/lib64/erlang/lib/runtime_tools-1.7.3/priv/lib/trace_file_drv.so
>> >> /usr/lib64/erlang/lib/runtime_tools-1.7.3/priv/lib/trace_ip_drv.so
>> >> /usr/lib64/erlang/lib/megaco-3.9.1.1/priv/lib/megaco_flex_scanner_drv_mt.so
>> >> /usr/lib64/erlang/lib/megaco-3.9.1.1/priv/lib/megaco_flex_scanner_drv.so
>> >> /usr/lib64/erlang/lib/erl_interface-3.5.9/bin/erl_call
>> >> /usr/lib64/erlang/lib/ssl-3.10/priv/bin/ssl_esock
>> >> /usr/lib64/erlang/lib/asn1-1.6.2/priv/lib/asn1_erl_drv.so
>> >> /usr/lib64/erlang/lib/crypto-1.5.3/priv/lib/crypto_drv.so
>> >> /usr/lib64/erlang/lib/common_test-1.3.4/priv/lib/erl_rx_driver.so
>> >> /usr/lib64/erlang/erts-5.6.5/bin/child_setup
>> >>
>> >> Before digging into the Makefiles, I'd like to know if you already
>> >> have some ideas about the root cause of this issue.
>> >>
>> >
>> > This bug is still present in R13A.
>> >
>> >  * QA Notice: Files built without respecting LDFLAGS have been detected
>> >  *  Please include the following list of files in your report:
>> >  * /usr/lib64/erlang/lib/runtime_tools-1.8/priv/lib/trace_file_drv.so
>> >  * /usr/lib64/erlang/lib/runtime_tools-1.8/priv/lib/trace_ip_drv.so
>> >  * /usr/lib64/erlang/lib/erl_interface-3.6/bin/erl_call
>> >  * /usr/lib64/erlang/lib/crypto-1.6/priv/lib/crypto_drv.so
>> >  * /usr/lib64/erlang/lib/megaco-3.10.0.1/priv/lib/megaco_flex_scanner_drv_mt.so
>> >  * /usr/lib64/erlang/lib/megaco-3.10.0.1/priv/lib/megaco_flex_scanner_drv.so
>> >  * /usr/lib64/erlang/lib/ssl-3.10.1/priv/bin/ssl_esock
>> >  * /usr/lib64/erlang/lib/asn1-1.6.8/priv/lib/asn1_erl_drv.so
>> >  * /usr/lib64/erlang/erts-5.7/bin/child_setup
>> >
>> > Best regards,
>> > Davide
>> >
>>
>> The attached patch fixes the problem for me: LDFLAGS are now respected.
>>
>> Regards,
>> Davide
>
> The patch looks great! It is unfortunately a few days late to make
> it into R13B. Now the source tree is labeled, and cut in stone.
> We have applied it, and it will be in the first patch release.
>
> We will also release it as a source code patch immediately
> after the R13B release.
>
> More patches like that! (and earlier)-:
>
>
> --
>
> / Raimo Niskanen, Erlang/OTP, Ericsson AB
>

As far as I can see the patch has not been applied, or at least it's
not present in R13B01. Has it been lost?

Regards,
Davide
-------------- next part --------------
A non-text attachment was scrubbed...
Name: erlang-R13B-LDFLAGS.patch
Type: application/octet-stream
Size: 4225 bytes
Desc: not available
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20090828/f1988d57/attachment.obj>