<div dir="ltr"><div>Ok the previous patch I sent (off list) did not got through my own tests.</div><div><br></div><div>I had to re-write the event handling but I think it got better.</div><div><br></div><div>Can you please test </div>
<a href="https://github.com/dgud/otp/compare/erlang:master...dgud%2Fwx%2Ffix-cb-cleanup">https://github.com/dgud/otp/compare/erlang:master...dgud%2Fwx%2Ffix-cb-cleanup</a><br><div><br></div><div>Or <a href="https://github.com/dgud/otp/tree/dgud/wx/fix-cb-cleanup">https://github.com/dgud/otp/tree/dgud/wx/fix-cb-cleanup</a></div>
<div><br></div><div>/Dan</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Feb 4, 2014 at 9:50 PM, Erlang <span dir="ltr"><<a href="mailto:erlang@not2cool.com" target="_blank">erlang@not2cool.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Dan<div><br></div><div>Great job, it works perfectly now.</div><div><br></div><div>Many thanks,</div>
<div><br></div><div>Tom</div><div><div class="h5"><div><br></div><div><div>On 4 Feb 2014, at 15:42, Dan Gudmundsson <<a href="mailto:dgud@erlang.org" target="_blank">dgud@erlang.org</a>> wrote:</div><br><blockquote type="cite">
<div dir="ltr">Ok figured out was it is, wx tries to disconnect the eventhandler i.e. the callback on the wxTextCtrl <div>when wxTextCtrl have been deleted already when the dialog was deleted.</div><div><br></div><div>Since wx did not create the textctrl (xrc does that) the cleanup mechanisms </div>
<div>doesn't get invoked when it is destructed.</div><div><br></div><div>Workaround is disconnect the callbacks to such objects before, destroying them..</div><div><br></div><div>Or delete the line:</div><div> Disconnect andalso (catch wxEvtHandler:disconnect_impl(CbH,O)),</div>
<div>in wxe_server </div><div><br></div><div>Which I will do in R17</div><div><br></div><div>Thanks for the bug report and test case.</div><div>/Dan</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jan 31, 2014 at 6:30 PM, Dan Gudmundsson <span dir="ltr"><<a href="mailto:dgud@erlang.org" target="_blank">dgud@erlang.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Ok, well then I will test more, write a test loop and see if I can reproduce it.<br>
</p>
<div class="gmail_quote">Den 31 jan 2014 17:57 skrev "Erlang" <<a href="mailto:erlang@not2cool.com" target="_blank">erlang@not2cool.com</a>>:<div><div><br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div>It does’t matter which way it’s closed. It’s the call to destroy that causes the crash (it doesn’t occur every time). </div><div><br></div><div>Tom</div><div><br></div><div><br></div>
<div><div><div>On 31 Jan 2014, at 16:50, Dan Gudmundsson <<a href="mailto:dgud@erlang.org" target="_blank">dgud@erlang.org</a>> wrote:</div><br><blockquote type="cite"><p dir="ltr">No just configure should work now.<br>
How do you close the window?<br>
I just pressed the ok button..</p>
<div class="gmail_quote">Den 31 jan 2014 17:38 skrev "Erlang" <<a href="mailto:erlang@not2cool.com" target="_blank">erlang@not2cool.com</a>>:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">Yeah with wx3.0 64bit. Are there any specific flags you pass to wx when building?<div><br></div><div>Cheers,<br><div><br><div>Tom <div><br></div><div><br><div><div>On 31 Jan 2014, at 16:23, Dan Gudmundsson <<a href="mailto:dgud@erlang.org" target="_blank">dgud@erlang.org</a>> wrote:</div>
<br><blockquote type="cite"><p dir="ltr">Ok with wx 3.0? 64 bit? <br>
I will test some more on monday, don't have a Mac at home.</p><p dir="ltr">Cheers</p>
<div class="gmail_quote">Den 31 jan 2014 16:31 skrev "Erlang" <<a href="mailto:erlang@not2cool.com" target="_blank">erlang@not2cool.com</a>>:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">Just tested on the pushed changes. The crash still occurs.<div><br></div><div>Regards,</div><div>Tom</div><div><br></div><div><br><div><div>On 31 Jan 2014, at 08:54, Dan Gudmundsson <<a href="mailto:dgud@erlang.org" target="_blank">dgud@erlang.org</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr">A new master branch have been pushed to github can you please test if it works now.<div>I guess you are already using wxWidgets-3.* something, or if not upgrade. </div><div><br>
</div>
<div>Regards</div><div>Dan</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jan 29, 2014 at 6:07 PM, Dan Gudmundsson <span dir="ltr"><<a href="mailto:dgud@erlang.org" target="_blank">dgud@erlang.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">I only tested with our internal master, give us a day or two to push the new things github. </p><p dir="ltr">
I will do another tomorrow with github master.<br>
Thanks for the good report.</p>
<div class="gmail_quote">Den 29 jan 2014 17:42 skrev "Erlang" <<a href="mailto:erlang@not2cool.com" target="_blank">erlang@not2cool.com</a>>:<div><br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div>Dan</div><div><br></div>I’ve just built the mater branch from GitHub, and the fault still occurs. I can prevent the fault occurring if I attach events to the wxDialog (parent), and not a child control, but this isn’t a complete solution. <div>
<br></div><div>Erlang solutions build with wx2.8 as far as I know.</div><div><br></div><div>Thanks,</div><div><br></div><div>Tom<br><div><br></div><div><br><div><div>On 29 Jan 2014, at 16:00, Dan Gudmundsson <<a href="mailto:dgud@erlang.org" target="_blank">dgud@erlang.org</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr">Can not reproduce with linux and wxWidgets-2.8.12 or wxWidgets-3.1 (i.e. master branch on github)<div>nor on darwin with erlang-r17-rc (coming soon) and wxWidgets-3.0</div><div>
<br>
</div><div>What wxWidgets is included in Mac R16B03 (32b) from erlang solutions? </div>
<div>Is that still wxWidgets-2.8 or is it wxWidgets-3.0? </div><div><br></div><div>I fixed some wx bugs in R16B03-1 and even more in the coming 17-rc so hopefully it should be fixed now.</div><div><br></div><div>Regards</div>
<div>/Dan</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jan 29, 2014 at 10:37 AM, Erlang <span dir="ltr"><<a href="mailto:erlang@not2cool.com" target="_blank">erlang@not2cool.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br>
<br>
Operating system: OSX 10.9.1<br>
Erlang version: R16B03<br>
Configure flags: —enable-darwin-64bit<br>
<br>
I’m getting a seg fault when the XRC dialog is destroyed. This also occurs on the 32bit pre-built binary of R16B03 from erlang-solutions (it does not occur on previous 32bit versions). It only occurs when event handlers are attached, and isn’t specifically related to XRC as I get the same error when I destroy a wx_object contained within a wxAuiNotebook (the XRC sample was easier to reproduce).<br>
<br>
Run xrc:test/0 and simply close the dialog in the provided sample to reproduce the bug (it might require a few attempts).<br>
<br>
Tom<br>
<br>
<br>
<br>_______________________________________________<br>
erlang-bugs mailing list<br>
<a href="mailto:erlang-bugs@erlang.org" target="_blank">erlang-bugs@erlang.org</a><br>
<a href="http://erlang.org/mailman/listinfo/erlang-bugs" target="_blank">http://erlang.org/mailman/listinfo/erlang-bugs</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div></div></div></blockquote></div></div>
</blockquote></div><br></div>
</blockquote></div><br></div></div></blockquote></div>
</blockquote></div><br></div></div></div></div></div></blockquote></div>
</blockquote></div><br></div></div></blockquote></div></div></div>
</blockquote></div><br></div>
</blockquote></div><br></div></div></div></blockquote></div><br></div>