[erlang-bugs] Observer table viewer crash - Patch???

[Matthew Evans]

Hi,
It should be off by default of course. But I found that by not setting the tuple {true,Time} or {false,Time} in observer_tv_table.erl would cause it to crash.
In my case the tables are quite small, so having a refresh every 20 seconds is pretty painless. Of course, for large tables I can see that you might want to warn the user that it's a really bad idea.
Thanks
Matt

> Date: Thu, 26 Jan 2012 08:35:07 +0100
> Subject: Re: [erlang-bugs] Observer table viewer crash - Patch???
> From: dangud@REDACTED
> To: mattevans123@REDACTED
> CC: erlang-bugs@REDACTED; erlang-patches@REDACTED
> 
> Thanks for the bug reports (and patches).
> 
> I did some late refactoring there, seems I broke a lot of things.
> I need to come up with away to automatically test at least the basic
> functionality.
> 
> The timer was off by default for tables, I didn't want it to
> automatically refresh since the
> tables can so large.
> 
> You think the tables should refresh automatically by default?
> 
> /Dan
> 
> On Wed, Jan 25, 2012 at 9:38 PM, Matthew Evans <mattevans123@REDACTED> wrote:
> > Ok, as well as the problem below it appears that observer_tv_table was
> > missing the handle_info/2 for the atom refresh_interval.
> >
> > The patch attached to this email appears to fix this.
> >
> > Feel free to try it...
> >
> > Again, I'm using R15B on Ubuntu.
> >
> > Thanks
> >
> > Matt
> >
> >
> > ________________________________
> > From: mattevans123@REDACTED
> > To: erlang-bugs@REDACTED
> > Date: Wed, 25 Jan 2012 13:06:27 -0500
> > Subject: Re: [erlang-bugs] Observer table viewer crash
> >
> > One additional point.
> >
> > I added the following tuple {true,20} to the "timer" parameter in the state
> > record of observer_tv_table.erl
> >
> > It didn't crash.
> >
> > What is interesting though is that it refreshed the "parent" window, not the
> > child window.
> >
> > Matt
> >
> > ________________________________
> > From: mattevans123@REDACTED
> > To: erlang-bugs@REDACTED
> > Date: Wed, 25 Jan 2012 11:20:18 -0500
> > Subject: [erlang-bugs] Observer table viewer crash
> >
> > Hi
> >
> > When I use the table viewer, select a table (any table) and "Edit->Refresh
> > Interval" I get the following error.
> >
> > I am running R15B on Ubuntu 11.10. Interestingly I can select "View->Refresh
> > Interval" from the table list window.
> >
> > The crash happens immediately, the dialog doesn't even open.
> >
> > Thanks
> >
> > Matt
> >
> >
> > Child crashed exiting:  <0.17131.1> {function_clause,
> >                                      [{observer_lib,interval_dialog,
> >                                        [{wx_ref,294,wxListCtrl,[]},
> >                                         undefined,10,300],
> >
> >  [{file,"observer_lib.erl"},{line,40}]},
> >                                       {observer_tv_table,handle_event,2,
> >                                        [{file,"observer_tv_table.erl"},
> >                                         {line,374}]},
> >                                       {wx_object,handle_msg,5,
> >                                        [{file,"wx_object.erl"},{line,394}]},
> >                                       {proc_lib,init_p_do_apply,3,
> >                                        [{file,"proc_lib.erl"},{line,227}]}]}
> > (plexxi@REDACTED)13>
> > =ERROR REPORT==== 25-Jan-2012::08:14:38 ===
> > ** wx object server <0.17134.1> terminating
> > ** Last message in was {wx,402,
> >                            {wx_ref,268,wxFrame,[]},
> >                            [],
> >                            {wxCommand,command_menu_selected,[],0,0}}
> > ** When Server state == {state,
> >                             {wx_ref,220,wxListCtrl,[]},
> >                             {wx_ref,268,wxFrame,[]},
> >                             {wx_ref,294,wxListCtrl,[]},
> >                             {wx_ref,285,wxStatusBar,[]},
> >                             {wx_ref,293,wxBoxSizer,[]},
> >                             {search,true,
> >                                 {wx_ref,295,wxBoxSizer,[]},
> >                                 'Search Area',
> >                                 {wx_ref,298,wxTextCtrl,[]},
> >                                 {wx_ref,309,wxTextCtrl,[]},
> >                                 {{wx_ref,300,wxRadioButton,[]},
> >                                  {wx_ref,302,wxRadioButton,[]},
> >                                  {wx_ref,304,wxCheckBox,[]}},
> >                                 undefined},
> >                             undefined,plexxi@REDACTED,2,<0.17135.1>,ets,
> >                             {tab,bob,81944,0,1228,<0.38.0>,ignore,protected,
> >                                 set,1,none,false,false,undefined,undefined},
> >                             {attrs,
> >                                 {wx_ref,287,wxListItemAttr,[]},
> >                                 {wx_ref,288,wxListItemAttr,[]},
> >                                 {wx_ref,289,wxListItemAttr,[]},
> >                                 {wx_ref,290,wxListItemAttr,[]},
> >                                 {wx_ref,291,wxListItemAttr,[]}},
> >                             undefined}
> > ** Reason for termination ==
> > ** {function_clause,
> >        [{observer_lib,interval_dialog,
> >             [{wx_ref,294,wxListCtrl,[]},undefined,10,300],
> >             [{file,"observer_lib.erl"},{line,40}]},
> >         {observer_tv_table,handle_event,2,
> >             [{file,"observer_tv_table.erl"},{line,374}]},
> >         {wx_object,handle_msg,5,[{file,"wx_object.erl"},{line,394}]},
> >         {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,227}]}]}
> >
> >
> > _______________________________________________ erlang-bugs mailing list
> > erlang-bugs@REDACTED http://erlang.org/mailman/listinfo/erlang-bugs
> >
> > _______________________________________________ erlang-bugs mailing list
> > erlang-bugs@REDACTED http://erlang.org/mailman/listinfo/erlang-bugs
> >
> > _______________________________________________
> > erlang-bugs mailing list
> > erlang-bugs@REDACTED
> > http://erlang.org/mailman/listinfo/erlang-bugs
> >
 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://erlang.org/pipermail/erlang-bugs/attachments/20120126/dfbc59f1/attachment.htm>