Dialyzer expand_files bug

[Ahmed Omar]

Hi there,
While using the dialyzer GUI, i found this bug. When you add a set of files
and directories (or directories only). The dialyzer will run analysis only
on one of the directories (last one processed).

The reason for that is the function expand_files/3 in module
dialyzer_analysis_callgraph. The function iterates over a list of files and
directories, when an item is a directory, it will replace
the accumulator with the list of files under that directory. It will
continue that behavior so eventually the output list is the last directory
processed plus files processed after it (but not other directories).

Please note that the command line version doesn't get affected by that cause
it does expand the directories into the list of underlying files before
sending them to dialyzer_analysis_callgraph module. (so it only gets a list
of files not directories).

Steps to reproduce:
1- dialyzer:gui().
2- Add dir1.
3- Add dir2.
4- Run analysis.

I will submit a patch soon.


-- 
Best Regards,
- Ahmed Omar
http://nl.linkedin.com/in/adiaa
Follow me on twitter
@spawn_think <http://twitter.com/#!/spawn_think>