[erlang-bugs] Fix building error of SCTP in FreeBSD 7.1 and later

Raimo Niskanen raimo+erlang-bugs@REDACTED
Wed Feb 10 16:39:45 CET 2010


On Wed, Feb 10, 2010 at 10:52:07PM +0900, Kenji Rikitake wrote:
> git fetch git://github.com/jj1bdx/otp.git r13b03_sctp_freebsd
> 
> Fix building error of SCTP in FreeBSD 7.1 and later
> 
> This patch fixes building error of SCTP in FreeBSD 7.1 and later.
> 
> See
> http://www.erlang.org/cgi-bin/ezmlm-cgi?2:mss:1257:200904:hppnfialjjdlgecdiehe
> for the details.

It seems Giacomo Olgeni's patch that this patch depends on
is missing. erts/configure will not define 
HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_SACKDELAY so it will
be disabled on all platforms even the ones that have
that flag... And that would be bad.

See also:
    http://www.erlang.org/cgi-bin/ezmlm-cgi/2/1264
sorry about me not managing to rework that issue,
other emergencies came in the way...

> 
> Patch summary:
> 
> R13A patch for solving a compilation error when building
> erts/emulator/drivers/common/inet_drv.c
> by Kenji Rikitake 12-APR-2009
> 
> Symptom solved by this patch:
> 
> When building R13A in FreeBSD 7.1-RELEASE,
> the compiler flag
> HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_SACKDELAY
> is NOT enabled.
> Some code in
> erts/emulator/drivers/common/inet_drv.c
> incorrectly assumes
> HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_SACKDELAY
> is always true when
> HAVE_STRUCT_SCTP_PADDRPARAMS_SPP_FLAGS
> is true in config.h.
> This assumption causes a compilation error.
> 
> Regards,
> Kenji Rikitake
> 
> ________________________________________________________________
> erlang-bugs (at) erlang.org mailing list.
> See http://www.erlang.org/faq.html
> To unsubscribe; mailto:erlang-bugs-unsubscribe@REDACTED

-- 

/ Raimo Niskanen, Erlang/OTP, Ericsson AB


More information about the erlang-bugs mailing list